-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to VPCs and RDS #814
base: master
Are you sure you want to change the base?
Commits on Sep 4, 2024
-
feat: allow disabling the proxy server and customize client server url (
#781) * show proxy ip address in deployment info * add ProxyInstanceCount and ServerURL configs - `ProxyInstanceCount` will determine how many proxy instances should be deployed. Default to 0, can be 0 or 1. - `ServerURL` determines the URL to use with the Mattermost client from the agent nodes. It takes precedence over the Site URL, proxy IP, etc. * downgrade elasticsearch dependency * ProxyInstanceCount default 0 * faq * feat: add concurrency to configureAndRunAgents * Better log tracing * Update docs/faq.md Co-authored-by: Alejandro García Montoro <[email protected]> * SAML configuration * ltkeycloak * typos * fixed slog calls * updated mattermost-realm.json * saml configuration * increase errorsChan buffer * revert: agent concurrency * docs: updated faq with SiteURL mention * NewPointer * refactor terraform app config * mlog, ctx, worker number * debug log * revert saml changes * make assets * go mod tidy * revert back channel to size 2, return early --------- Co-authored-by: Alejandro García Montoro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 002c986 - Browse repository at this point
Copy the full SHA 002c986View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2467c9 - Browse repository at this point
Copy the full SHA d2467c9View commit details
Commits on Sep 17, 2024
-
[MM-60371] Update Pyroscope to v1 (#793)
* Update Pyroscope v1 Add support for goroutine and block profiles * Unify service name for targets * Update test
Configuration menu - View commit details
-
Copy full SHA for 1ded5bc - Browse repository at this point
Copy the full SHA 1ded5bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfd403f - Browse repository at this point
Copy the full SHA dfd403fView commit details -
MM-56605: Create results file and print to file (#729)
* MM-56605: Create results file and print to file * Separate writter into its own function for later * Mofify writeToFile. Passing the file object. * implement multiWriter so I can double the writes and then send them to cosole as well as file. * Replace file object with interface. * - Remove separate function to create file - Move file creatuin and writting to the file to Comparison function * Draft unti test for PrintResults * Make test runnable by using LoadTests and Status properly. * - Solve missing use of interface in the initail code chnage - Solve whitespace mismatch * Change expected to allign with the output. This solves failing unit test. * Address most several of the code review feedback point. * Use existing file path that is already being provided to the function. * Address linter complaint about use of `Sprintf` for strings that need no formating. * Address review comments * Remove line printing an error as it was redundant. * Update another if block that redundantly prints and returns the same error. * Implement missed correction from Alejandro. If block must return the correct var when returning the error. Ensure this is not occuring on other lines I've added.
Configuration menu - View commit details
-
Copy full SHA for f3bf239 - Browse repository at this point
Copy the full SHA f3bf239View commit details -
Restore the saml-idp.crt file in assets (#792)
Without this line, the deployment fails because it cannot do t.getAsset
Configuration menu - View commit details
-
Copy full SHA for 1ddbd16 - Browse repository at this point
Copy the full SHA 1ddbd16View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 42e42f5 - Browse repository at this point
Copy the full SHA 42e42f5View commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 155c12e - Browse repository at this point
Copy the full SHA 155c12eView commit details -
feat(ltkeycloak): added flag to force migrate all users (#802)
* ltkeycloak: added flag to force migrate all users * changed flag * avoid logging and returning error * modified comment * remove duplicated restoreasset * reverted condition to return early * check for nil values * use UpdateUserAuth * rename variable name * Update cmd/ltkeycloak/from_mattermost.go Co-authored-by: Alejandro García Montoro <[email protected]> --------- Co-authored-by: Alejandro García Montoro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0497039 - Browse repository at this point
Copy the full SHA 0497039View commit details
Commits on Sep 26, 2024
-
Setup VPC parameter for all resources and allow custom database engin…
…e version (#813) * customizable database engine version * Use same VPC for all resources * make assets * removed engineversion validation * wait for stdout * use default subnet if not specified
Configuration menu - View commit details
-
Copy full SHA for e4a29f0 - Browse repository at this point
Copy the full SHA e4a29f0View commit details
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 86222d4 - Browse repository at this point
Copy the full SHA 86222d4View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7535b0a - Browse repository at this point
Copy the full SHA 7535b0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c21c7f - Browse repository at this point
Copy the full SHA 7c21c7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c6c729 - Browse repository at this point
Copy the full SHA 2c6c729View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc68578 - Browse repository at this point
Copy the full SHA dc68578View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59020dc - Browse repository at this point
Copy the full SHA 59020dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e051958 - Browse repository at this point
Copy the full SHA e051958View commit details -
Configuration menu - View commit details
-
Copy full SHA for d41273e - Browse repository at this point
Copy the full SHA d41273eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93d5166 - Browse repository at this point
Copy the full SHA 93d5166View commit details -
Configuration menu - View commit details
-
Copy full SHA for d46c448 - Browse repository at this point
Copy the full SHA d46c448View commit details -
Configuration menu - View commit details
-
Copy full SHA for 737fc20 - Browse repository at this point
Copy the full SHA 737fc20View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2c6466 - Browse repository at this point
Copy the full SHA f2c6466View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef654a5 - Browse repository at this point
Copy the full SHA ef654a5View commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e6da243 - Browse repository at this point
Copy the full SHA e6da243View commit details -
Configuration menu - View commit details
-
Copy full SHA for baef7cc - Browse repository at this point
Copy the full SHA baef7ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef0492a - Browse repository at this point
Copy the full SHA ef0492aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8ecc1a - Browse repository at this point
Copy the full SHA b8ecc1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b11850f - Browse repository at this point
Copy the full SHA b11850fView commit details
Commits on Oct 22, 2024
-
[MM-61113] Allow multiple customizable subnets (#833)
* multiple subnet support * wait for terraform stdout * revert elasticsearch zone awareness * fixed line removed on merge conflict * AWSAvailabilityZone compatibility * support a single subnet in db groups * refactor to use explicit subnets * elasticsearch multiple subnet support * docs * review comments * use list of subnets for all resources * tags for db-subnet-group * updated sample files * aws_db_subnet_group -> aws_elasticcache_subnet_group * use reflect.DeepEqual to simplify code * Update docs/config/deployer.md Co-authored-by: Alejandro García Montoro <[email protected]> * Update deployment/config.go Co-authored-by: Alejandro García Montoro <[email protected]> * docs link to aws docs * function to struct method --------- Co-authored-by: Alejandro García Montoro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 862c4e3 - Browse repository at this point
Copy the full SHA 862c4e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e85cc89 - Browse repository at this point
Copy the full SHA e85cc89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62f7793 - Browse repository at this point
Copy the full SHA 62f7793View commit details -
Configuration menu - View commit details
-
Copy full SHA for 032b359 - Browse repository at this point
Copy the full SHA 032b359View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3e69d1 - Browse repository at this point
Copy the full SHA b3e69d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b733c03 - Browse repository at this point
Copy the full SHA b733c03View commit details
Commits on Oct 23, 2024
-
My editor wants to make the Terraform files pretty.
Configuration menu - View commit details
-
Copy full SHA for 24e7a30 - Browse repository at this point
Copy the full SHA 24e7a30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c4e3e4 - Browse repository at this point
Copy the full SHA 8c4e3e4View commit details -
Remove deleted ElasticSearchSettings.VpcID
This field does no longer exist, we can remove it from the sample files and documentation
Configuration menu - View commit details
-
Copy full SHA for b7a4ed2 - Browse repository at this point
Copy the full SHA b7a4ed2View commit details -
String() needs to be in the plain type method set
The method set of a type does not contain the methods on its pointer. For fmt.Sprintf and friends to use it when using the "%s" formatter, we need the method to be defined in the plain type.
Configuration menu - View commit details
-
Copy full SHA for de13532 - Browse repository at this point
Copy the full SHA de13532View commit details -
Use the correct type in reflect.MakeSlice
MakeSlice expects its first argument to be the type of a slice, not the type of the underlying elements of a slice; i.e., we need to pass `[]string`, not `string`. Before this commit, we were passing the type of the slice's Elem(), which is the type of the underlying elements.
Configuration menu - View commit details
-
Copy full SHA for 0b92ca1 - Browse repository at this point
Copy the full SHA 0b92ca1View commit details -
Default ClusterSubnetIDs' slices to non-nil slices
Defaulting the size of each slice to 0, we make sure the slices are not nil, but valid empty slices.
Configuration menu - View commit details
-
Copy full SHA for eb77bbf - Browse repository at this point
Copy the full SHA eb77bbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ff58ad - Browse repository at this point
Copy the full SHA 2ff58adView commit details -
Iterate over all fields of the ClusterSubnetIDs struct that are slices and actually check at least one is non-nil with length greater than 0
Configuration menu - View commit details
-
Copy full SHA for cfb64cf - Browse repository at this point
Copy the full SHA cfb64cfView commit details -
Check length of subnet lists instead of empty str
Now that we validate that var.cluster_subnet_ids.xyz's length is larger than 0, we allow both: 1. Unset lists, which are indeed serialized as empty strings. The length of an empty string is still 0. 2. Empty lists, which are serialized as lists, but that are not equal to the empty string. If we only check for the empty string, we lose 2.
Configuration menu - View commit details
-
Copy full SHA for 9c00922 - Browse repository at this point
Copy the full SHA 9c00922View commit details -
Use proper subnets in DB cluster and Redis
We were checking for the length of the `cluster_subnet_ids` variable, not the underlying `redis` or `database` lists, which are the ones we later use in these definitions.
Configuration menu - View commit details
-
Copy full SHA for 7214588 - Browse repository at this point
Copy the full SHA 7214588View commit details -
Get default VPC and use it to define subnets
If we don't define the VPC, leaving ClusterVPCID empty or unset, the data.aws_subnets.selected list ends up being empty, since we filter for subnets that are contained in such VPC. To fix this, we retrieve the default VPC, and use its ID to filter the subnets to select if no VPC is explicitly set.
Configuration menu - View commit details
-
Copy full SHA for d93f792 - Browse repository at this point
Copy the full SHA d93f792View commit details -
Make the AZ filter on subnets conditional
Similar to the VPC change, we filter the selected subnets by their availability zone *only* if the `AWSAvailabilityZone` setting is non-empty.
Configuration menu - View commit details
-
Copy full SHA for 5aa7518 - Browse repository at this point
Copy the full SHA 5aa7518View commit details -
Remove subnet_id if not specified
If the user doesn't specify a subnet for a resource, we don't need to pick one for it, we just set the subnet_id to null.
Configuration menu - View commit details
-
Copy full SHA for 8b725dd - Browse repository at this point
Copy the full SHA 8b725ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9e2dee - Browse repository at this point
Copy the full SHA d9e2deeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45da4f3 - Browse repository at this point
Copy the full SHA 45da4f3View commit details
Commits on Oct 24, 2024
-
Apply suggestions from code review
Subnet groups require 2+ subnets Co-authored-by: Felipe Martin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c72700c - Browse repository at this point
Copy the full SHA c72700cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1dba81 - Browse repository at this point
Copy the full SHA e1dba81View commit details -
Configuration menu - View commit details
-
Copy full SHA for c278150 - Browse repository at this point
Copy the full SHA c278150View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76b5d00 - Browse repository at this point
Copy the full SHA 76b5d00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15953aa - Browse repository at this point
Copy the full SHA 15953aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2496b65 - Browse repository at this point
Copy the full SHA 2496b65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0870690 - Browse repository at this point
Copy the full SHA 0870690View commit details -
Configuration menu - View commit details
-
Copy full SHA for b49ab37 - Browse repository at this point
Copy the full SHA b49ab37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51d1afc - Browse repository at this point
Copy the full SHA 51d1afcView commit details -
Configuration menu - View commit details
-
Copy full SHA for bad542c - Browse repository at this point
Copy the full SHA bad542cView commit details
Commits on Oct 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 10e97dc - Browse repository at this point
Copy the full SHA 10e97dcView commit details