Add Channel bookmarks to loadtest #828
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| // Copyright (c) 2019-present Mattermost, Inc. All Rights Reserved. | ||
| // See License.txt for license information. | ||
|
|
||
| package simulcontroller | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "math/rand" | ||
|
|
||
| "github.com/mattermost/mattermost-load-test-ng/loadtest/control" | ||
| "github.com/mattermost/mattermost-load-test-ng/loadtest/user" | ||
| "github.com/mattermost/mattermost/server/public/model" | ||
| ) | ||
|
|
||
| var ( | ||
| bookmarkNames = []string{"this is a file", "this is a link", "this is another file", "this is another link"} | ||
| bookmarkType = []model.ChannelBookmarkType{model.ChannelBookmarkLink, model.ChannelBookmarkFile} | ||
| ) | ||
|
|
||
| func (c *SimulController) addBookmark(u user.User) control.UserActionResponse { | ||
| channel, err := u.Store().CurrentChannel() | ||
| if err != nil { | ||
| return control.UserActionResponse{Err: control.NewUserError(err)} | ||
| } | ||
|
|
||
| emoji := "" | ||
| // 10% of the times bookmarks will have an emoji assigned. | ||
agnivade marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if rand.Float64() < 0.1 { | ||
| emoji = control.RandomEmoji() | ||
| } | ||
|
|
||
| bookmark := &model.ChannelBookmark{ | ||
| ChannelId: channel.Id, | ||
| DisplayName: control.PickRandomString(bookmarkNames), | ||
| Emoji: emoji, | ||
| Type: bookmarkType[rand.Intn(len(bookmarkType))], | ||
| } | ||
|
|
||
| if bookmark.Type == model.ChannelBookmarkFile { | ||
| control.AttachFileToBookmark(u, bookmark) | ||
| } else { | ||
| bookmark.LinkUrl = control.RandomLink() | ||
| } | ||
|
|
||
| err = u.AddChannelBookmark(channel.Id, bookmark) | ||
| if err != nil { | ||
| return control.UserActionResponse{Err: control.NewUserError(err)} | ||
| } | ||
|
|
||
| return control.UserActionResponse{Info: fmt.Sprintf("bookmark created in channel id %v", channel.Id)} | ||
| } | ||
|
|
||
| func (c *SimulController) AddChannelBookmark(u user.User) control.UserActionResponse { | ||
| if ok, resp := control.ChannelBookmarkEnabled(u); resp.Err != nil { | ||
| return resp | ||
| } else if !ok { | ||
| return control.UserActionResponse{Info: "channel bookmarks not enabled"} | ||
| } | ||
|
|
||
| return c.addBookmark(u) | ||
| } | ||
|
|
||
| func (c *SimulController) UpdateOrAddBookmark(u user.User) control.UserActionResponse { | ||
|
There was a problem hiding this comment. Looking at the server API, there is no updateOrAdd API. Just individual update and add. Could we do the same here? Or do we need to keep the add logic if there are no bookmarks? There was a problem hiding this comment. I can just make sure that if the channel has no bookmarks, nothing happens |
||
| if ok, resp := control.ChannelBookmarkEnabled(u); resp.Err != nil { | ||
| return resp | ||
| } else if !ok { | ||
| return control.UserActionResponse{Info: "channel bookmarks not enabled"} | ||
| } | ||
|
|
||
| channel, err := u.Store().CurrentChannel() | ||
| if err != nil { | ||
| return control.UserActionResponse{Err: control.NewUserError(err)} | ||
| } | ||
|
|
||
| currentBookmarks := u.Store().ChannelBookmarks(channel.Id) | ||
| if len(currentBookmarks) > 0 { | ||
| // here we update | ||
| bookmark := currentBookmarks[rand.Intn(len(currentBookmarks))] | ||
| if bookmark != nil { | ||
|
|
||
| bookmarkWithFileInfo := bookmark.Clone() | ||
| bookmarkWithFileInfo.DisplayName = control.PickRandomString(bookmarkNames) | ||
|
|
||
| // 10% of the times bookmarks will have an emoji assigned. | ||
| if bookmarkWithFileInfo.Emoji == "" && rand.Float64() < 0.1 { | ||
| bookmarkWithFileInfo.Emoji = control.RandomEmoji() | ||
| } | ||
|
|
||
| if bookmarkWithFileInfo.Type == model.ChannelBookmarkFile { | ||
| control.AttachFileToBookmark(u, bookmarkWithFileInfo.ChannelBookmark) | ||
| } else { | ||
| bookmarkWithFileInfo.LinkUrl = control.RandomLink() | ||
| } | ||
|
|
||
| err = u.UpdateChannelBookmark(bookmarkWithFileInfo) | ||
|
|
||
| if err != nil { | ||
| return control.UserActionResponse{Err: control.NewUserError(err)} | ||
| } | ||
|
|
||
| return control.UserActionResponse{Info: fmt.Sprintf("bookmark %v updated in channel id %v", bookmarkWithFileInfo.Id, channel.Id)} | ||
| } | ||
| } | ||
|
|
||
| return c.addBookmark(u) | ||
| } | ||
|
|
||
| func (c *SimulController) DeleteBookmark(u user.User) control.UserActionResponse { | ||
| if ok, resp := control.ChannelBookmarkEnabled(u); resp.Err != nil { | ||
| return resp | ||
| } else if !ok { | ||
| return control.UserActionResponse{Info: "channel bookmarks not enabled"} | ||
| } | ||
|
|
||
| channel, err := u.Store().CurrentChannel() | ||
| if err != nil { | ||
| return control.UserActionResponse{Err: control.NewUserError(err)} | ||
| } | ||
|
|
||
| currentBookmarks := u.Store().ChannelBookmarks(channel.Id) | ||
| if len(currentBookmarks) > 0 { | ||
| bookmark := currentBookmarks[rand.Intn(len(currentBookmarks))] | ||
| if bookmark != nil { | ||
|
|
||
| err = u.DeleteChannelBookmark(bookmark.ChannelId, bookmark.Id) | ||
| if err != nil { | ||
| return control.UserActionResponse{Err: control.NewUserError(err)} | ||
| } | ||
|
|
||
| return control.UserActionResponse{Info: fmt.Sprintf("bookmark id %v deleted in channel id %v", bookmark.Id, channel.Id)} | ||
| } | ||
| } | ||
|
|
||
| return control.UserActionResponse{Info: "no channel bookmarks deleted"} | ||
|
There was a problem hiding this comment. Maybe a better string would be "no channel bookmarks found"? |
||
| } | ||
|
|
||
| func (c *SimulController) UpdateBookmarksSortOrder(u user.User) control.UserActionResponse { | ||
| if ok, resp := control.ChannelBookmarkEnabled(u); resp.Err != nil { | ||
| return resp | ||
| } else if !ok { | ||
| return control.UserActionResponse{Info: "channel bookmarks not enabled"} | ||
| } | ||
|
|
||
| channel, err := u.Store().CurrentChannel() | ||
| if err != nil { | ||
| return control.UserActionResponse{Err: control.NewUserError(err)} | ||
| } | ||
|
|
||
| currentBookmarks := u.Store().ChannelBookmarks(channel.Id) | ||
| if len(currentBookmarks) > 1 { | ||
| bookmark := currentBookmarks[rand.Intn(len(currentBookmarks))] | ||
| newIndex := rand.Int63n(int64(len(currentBookmarks))) | ||
| if bookmark != nil { | ||
| err = u.UpdateChannelBookmarkSortOrder(channel.Id, bookmark.Id, newIndex) | ||
| if err != nil { | ||
| return control.UserActionResponse{Err: control.NewUserError(err)} | ||
| } | ||
|
|
||
| return control.UserActionResponse{Info: fmt.Sprintf("bookmark id %v in channel id %v sorted at index %d", bookmark.Id, channel.Id, newIndex)} | ||
| } | ||
| } | ||
|
|
||
| return control.UserActionResponse{Info: "not enough channel bookmarks to sort"} | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh my dear ..
https://hub.mattermost.com/private-core/pl/hih74enmn7bwunmy6eamgct67r
Let's fix it everywhere else as well :)
I also mentioned this additionally in the dev meeting, but probably I could have done a better job.