Update to use the new version of mattermost-redux #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update import path for createSelector
Update name of fetchChannelsAndMembers and update channelsByTeam type Properly type preference get selector
I can't figure out why Jest can't find these files given other tools can use the mappings in the package.json when other tools can. I have a hard time telling if Jest should support that feature or not, but I've spent enough time fighting with that to decide that I should leave it as-is for now.
hmhealey
added
2: Dev Review
hmhealey
changed the title
lieut-data
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
This looks great, @hmhealey! Thank you for the heavy lifting :)
cc @esarafianou, as this will resolve a number of the warning re: the old webapp dependency.
NOTICE.txt
Outdated
There was a problem hiding this comment.
Propose either omitting the changes to this file and letting the automation submit a PR to do so, or explicitly running https://github.com/mattermost/notice-file-generator to effect all required changes. (If the files don't perfectly match that output, we'll get an automated PR clobbering these changes anyway.)
This is awesome! 😍 |
calebroseland
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of trying to start publishing mattermost-redux again, I've used Playbooks as a test bed to ensure that the published package actually works since it's the first time that we've published it from a monorepo and because I'm trying to do things "the right way" versus the old mattermost-redux package which was rather clunky and required a lot of workarounds.
The commits for this can be roughly broken down into a few categories:
mattermost-webappdependency withmattermost-reduxor@mattermost/typesmattermost-reduxand removing the overrides to make the previous ones work (except for Jest which I fought with for hours and gave up on)mattermost-reduxThis is a draft for now since it's using a prerelease version of
mattermost-reduxand the@mattermostpackages.Web app PR: mattermost/mattermost#30020