re-implement Lockable interface to drop requirement on driver impls. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isacikgoz
force-pushed
the
improve-lockable-interface
branch
from
aa4f32f
to
de86c1b
Compare
isacikgoz
force-pushed
the
improve-lockable-interface
branch
from
de86c1b
to
303b582
Compare
agnivade
reviewed
Oct 24, 2024
agarciamontoro
approved these changes
Oct 24, 2024
agnivade
approved these changes
Oct 25, 2024
isacikgoz
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This just bugged me. First of all, we should always return concrete types, this was just a remnant from initial implementation. No need to carry on. Apart from that, we are expecting driver itself to implement
Lockableinterface that returns an actualLockerinterface.We still support drivers can do Lock and can't. Even though there shouldn't be a code change required, this can be targeted for
v2.