[MM-60189] Rate limit forwarding PLI requests #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
added
3: Reviews Complete
streamer45
force-pushed
the
MM-60189
branch
from
5b4c9fd to
3545a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sending keyframes can be expensive for the presenter, as it requires more bandwidth. It gets worse when N receivers concurrently ask for a keyframe. This is common when a presenter begins screen sharing in a large call.
PR introduces some rate limiting to avoid forwarding more than 1 PLI (picture loss indication) request per second.
Ticket Link
https://mattermost.atlassian.net/browse/MM-60189