Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'start_seconds' and 'end_seconds' bug + "all day" bug #4

Open
MarioPadilla opened this issue Oct 26, 2016 · 1 comment
Open

'start_seconds' and 'end_seconds' bug + "all day" bug #4

MarioPadilla opened this issue Oct 26, 2016 · 1 comment

Comments

@MarioPadilla
Copy link

MarioPadilla commented Oct 26, 2016 •
edited
Loading

icsformatter_issue

On the lines 63 and 70, we must to save getSeconds() instead of getMinutes() to 'start_seconds' and 'end_seconds' variables.

For other hand, when we're saving exact hours, for example, 11:00 to 12:00, on the line 75 recognise that is an event without time (is wrong).

In the image you can check the solutions ; )
@ghost
Copy link

ghost commented Sep 8, 2017

I think original developer of ics.js though that is unnecessary since you don't use seconds when saving and event.

will-russell added a commit to will-russell/icsFormatter that referenced this issue Sep 4, 2019
@will-russell
Correct seconds calculations, "all day" bug
2218c7e 
fixes matthiasanderer#4 

Set seconds variables to actual seconds instead of minutes.
Include start and end hours in check for "all day" status - if time is "11:00:00" to "12:00:00" it should show as one hour, not "all day".
@will-russell will-russell mentioned this issue Sep 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct seconds calculations, "all day" bug, use GMT times will-russell/icsFormatter
1 participant
@MarioPadilla