Correct seconds calculations, "all day" bug, use GMT times #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes matthiasanderer#4 Set seconds variables to actual seconds instead of minutes. Include start and end hours in check for "all day" status - if time is "11:00:00" to "12:00:00" it should show as one hour, not "all day".
Remove "VALUE=DATE" sub statement to allow utilizing times for non-all day events. "VALUE=DATE" should remain for events that are midnight-to-midnight.
will-russell
changed the title
Offset start and end date by the time zone offset so that the hours, etc. will be in UTC instead of local time. Note that the timezone of the dates is unaffected - we are simply offsetting by the time zone offset so that we can get the year, month, days, hours, and minutes from the equivalent UTC time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4
Ensure that GMT year, month, day, hour, and minute are used for the ICS values (which are to be in "Zulu", or "GMT" time).
Set seconds variables to actual seconds instead of minutes.
Include start and end hours in check for "all day" status - if time is "11:00:00" to "12:00:00" it should show as one hour, not "all day".