Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use triple equals for dates #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JamesGelok
Copy link

Not sure what would need to be coerced here, triple equals might help ensure a more accurate diff.

sample source

const date1 = new Date(Date.UTC(96, 1, 2, 3, 4, 5));

console.log(date1.valueOf());
// expected output: 823230245000

const date2 = new Date("02 Feb 1996 03:04:05 GMT");

console.log(date2.valueOf());
// expected output: 823230245000

After looking at this I'm thinking we should use triple equals here.

console.log(date1.valueOf() === date2.valueOf());
// expected output: true

Not sure what would need to be coerced here, triple equals might help ensure a more accurate diff. 


```js
  const date1 = new Date(Date.UTC(96, 1, 2, 3, 4, 5));

  console.log(date1.valueOf());
  // expected output: 823230245000

  const date2 = new Date("02 Feb 1996 03:04:05 GMT");

  console.log(date2.valueOf());
  // expected output: 823230245000

  console.log(date1.valueOf() === date2.valueOf());
  // expected output: true
```
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 49e6212 on JamesGelok:patch-1 into 6296889 on mattphillips:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants