Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test current PR build and add local registry in KinD #1

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

matzhaugen
Copy link
Owner

@matzhaugen matzhaugen commented Feb 17, 2021

Test current PR build and add local registry in KinD

Description

This PR does a few things:

  1. Tests the current faas-netes image in the integration test with the KinD cluster in the CI job. I use a github action for setting up the kind cluster.
  2. The kind cluster adds a local registry to which we push the fresh image from the current PR.
  3. Separates the multiarch build with buildx and the integration test and thus reduces the PR build time by 50% from 12m to 6 min.
  4. The image can now be built locally and pushed to the kind-registry for faster testing of a new faas-netes image.
  5. Add load testing script in contrib/load_test.sh which currently requires hey.

Motivation and Context

How Has This Been Tested?

  • The CI job passes with a new image
  • The create_dev.sh script works now

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

add reg args
@matzhaugen matzhaugen changed the title Add local registry Test current PR build and add local registry in KinD Feb 19, 2021
@matzhaugen matzhaugen marked this pull request as draft February 19, 2021 14:19
@matzhaugen matzhaugen closed this Feb 19, 2021
@matzhaugen matzhaugen reopened this Feb 19, 2021
@@ -3,37 +3,53 @@ name: build
on:
push:
branches: [ '*' ]
pull_request:
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build was building twice for each push so I removed this. I can put it back in if you want.

@matzhaugen matzhaugen marked this pull request as ready for review February 19, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant