fix "uninitialized value" warnings for readline()

Like getc or (sys)read, readline can return undef even if its argument is fully defined.
mauke · Feb 7, 2024 · 34c5e5b · 34c5e5b
1 parent b9a5b9e
commit 34c5e5b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/sv.c b/sv.c
@@ -17408,6 +17408,7 @@ S_find_uninit_var(pTHX_ const OP *const obase, const SV *const uninit_sv,
     case OP_TIED:
     case OP_GETC:
     case OP_SYSREAD:
+    case OP_READLINE:
     case OP_SEND:
     case OP_IOCTL:
     case OP_SOCKET:

diff --git a/t/lib/warnings/9uninit b/t/lib/warnings/9uninit
@@ -1673,6 +1673,13 @@ Use of uninitialized value in addition (+) at - line 4.
 use warnings 'uninitialized';
 my $nofile = '/no/such/file';
 my $v;
+$v = 1 + readline($nofile);
+EXPECT
+Use of uninitialized value in addition (+) at - line 4.
+########
+use warnings 'uninitialized';
+my $nofile = '/no/such/file';
+my $v;
 $v = 1 + eval { send($nofile, $buf,0) };
 EXPECT
 Use of uninitialized value in addition (+) at - line 4.