Remove sequence token for PutLogEvents #115
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
On January 4, 2023, Amazon announced that the sequence token is no longer required for
PutLogEvents
. This PR updates the library to reflect this new change and also adds functionality to emulatecreateGroup
for log streams.What is the current behavior? (You can also link to an open issue here)
The
refreshSequenceToken()
function gets called somewhat regularly throughout the code.What is the new behavior (if this is a feature change)?
No more
refreshSequenceToken()
or associated calls!Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Based upon my initial testing, this does not cause a breaking change -- I was able to slide this in seamlessly without any issues in my environment. The AWS announcement notes that this change is available in all commercial regions which, I assume, means that ex. GovCloud doesn't have support for this? But the API Documentation doesn't reflect this limitation... 🤷
This does open up the possibility for users to leverage the new
createStream
constructor option to skip thedescribeLogGroups
calls (which can cause issues similar to fix AWS Limits Race-Condition #113 and, frankly, is the reason I'm doing this in the first place).Other information:
This is also addressed in request [FEATURE] Update to match changes in Cloudwatch #114.