-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug tracking : Clean up #6
Open
maxiim3
wants to merge
21
commits into
main
Choose a base branch
from
refactor/widget-album-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom new-ui branch
…eCalculatePosition hook
… to useHandleVideoProps hook
…usage in hero-section.tsx
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
…, integrated LitElement in Heading2 component, and modified tsconfig.json for experimentalDecorators and useDefineForClassFields.
…component functionality in various files
…embers.tsx, added @vanilla-extract/next-plugin dependency, and integrated Vanilla Extract in next.config.js
…stcss-nesting dependency, and improved layout and theme configurations. Replace the hook with a React Context
…ider and revealFromBottom animation.
… for responsive design
…ved component functionality, and adjusted import statements.
…de lines with optimized ones. Minor changes in file2.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Main theme:
This PR mainly focuses on refactoring and enhancing the AlbumSlider component and adding a new Carousel component. It also includes updates to various other components and hooks, and the removal of unused components.
🏷️ PR labels: Refactoring Enhancement
📝 PR summary:
The PR introduces a significant refactor of the AlbumSlider component, including the addition of detailed comments and improvements to the useCalculatePosition hook. A new Carousel component is also added. Other changes include updates to various UI components, hooks, and the navigation structure. Several unused components have been removed.
🧪 Relevant tests added: No
⏱️ Estimated effort to review [1-5]:
4, due to the large number of changes across multiple files, including significant refactoring and enhancement of existing components. The addition of a new component also adds to the complexity of the review.