Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug tracking : Clean up #6

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

maxiim3
Copy link
Owner

@maxiim3 maxiim3 commented Dec 30, 2023

🎯 Main theme:
This PR mainly focuses on refactoring and enhancing the AlbumSlider component and adding a new Carousel component. It also includes updates to various other components and hooks, and the removal of unused components.
🏷️ PR labels: Refactoring Enhancement
📝 PR summary:
The PR introduces a significant refactor of the AlbumSlider component, including the addition of detailed comments and improvements to the useCalculatePosition hook. A new Carousel component is also added. Other changes include updates to various UI components, hooks, and the navigation structure. Several unused components have been removed.
🧪 Relevant tests added: No
⏱️ Estimated effort to review [1-5]:
4, due to the large number of changes across multiple files, including significant refactoring and enhancement of existing components. The addition of a new component also adds to the complexity of the review.

@maxiim3 maxiim3 added bug Something isn't working enhancement New feature or request wontfix This will not be worked on labels Dec 30, 2023
Copy link

vercel bot commented Dec 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
legendis ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 7:55pm

Copy link

socket-security bot commented Dec 30, 2023

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@radix-ui/react-progress 1.0.3 None +1 285 kB benoitgrelard
@lit/react 1.0.2 None +0 146 kB lit-robot
lit 3.1.0 None +5 2.76 MB lit-robot
postcss-nesting 12.0.2 None +1 38.4 kB romainmenke
embla-carousel-react 8.0.0-rc17 None +2 562 kB davidjerleke
@vanilla-extract/next-plugin 2.3.2 environment +165 428 MB vanilla-extract-css
next-sanity 7.0.5 environment +460 555 MB sanity-io
tailwindcss 3.3.3...3.4.0 None +1/-1 5.75 MB adamwathan
daisyui 3.9.4...4.4.24 None +1/-3 3.96 MB saadeghi
framer-motion 10.16.4...10.16.16 None +0/-0 2.09 MB popmotion

…, integrated LitElement in Heading2 component, and modified tsconfig.json for experimentalDecorators and useDefineForClassFields.
…embers.tsx, added @vanilla-extract/next-plugin dependency, and integrated Vanilla Extract in next.config.js
…stcss-nesting dependency, and improved layout and theme configurations. Replace the hook with a React Context
…ved component functionality, and adjusted import statements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant