-
Notifications
You must be signed in to change notification settings - Fork 41
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
LiveView 1.0 adds support for interpolation using curly braces (`{...}`) instead of angle brackets (`<%= ... %>`)[0]. This caused a compilation error in `ShowcaseLive`, because we return literal curly braces in the HTML. The fix is to either use `{` or `<%= "{" %>`[1]. I think the former is nicer, so that's what I've done here. If you disagree, I'm happy to change it. I've also changed some instances of `live_flash/2` to `Phoenix.Flash.get/2`, as `live_flash/2` is now deprecated[2] Fixes: #88 0: https://hexdocs.pm/phoenix_live_view/Phoenix.Component.html#sigil_H/2-interpolation 1: phoenixframework/phoenix_live_view#3554 2: https://hexdocs.pm/phoenix_live_view/changelog.html#deprecations-1
- Loading branch information
1 parent
b2707dd
commit 129f7bd
Showing
4 changed files
with
23 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.