Adding pprof flag to support better tracing & rewriting file watching #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @maxpert How do you feel about merging this. Will be useful for debugging. |
maxpert
commented
Aug 2, 2024
|
|
||
| for { | ||
| changeLogTicker.Reset() | ||
|
|
||
| err := conn.WithReadTx(func(_tx *sql.Tx) error { | ||
| select { | ||
| case ev, ok := <-watcher.Events: | ||
| case ev, ok := <-dbChanged: |
There was a problem hiding this comment.
I don't see the point of adding another channel and doing the same thing that we are doing in the body of the function. This one new channel + go routine might not be a big deal, but unless there is sophisticated logic adding such additional go routines and channels is just gonna keep on increasing memory overhead.
|
thanks @maxpert for this. It will make it much easier to work on. I will try out running Pocket base with a NATS Cluster and see if I can help with optimisation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out people were noticing high CPU usage due to fsnotify flooding Marmot with
fsnotify.Chmod. This PR introduces pprof flag to run marmot with profiling and fixes the issue.