Fix: NoMethodError (MAYBE-MARKETING-3X)

[revise-dev]

The error occurs because the blank? method is trying to call zero? directly on potentially nil values. While the attributes have default values of 0.0 defined in the class, there are scenarios where these values could still be nil, such as during form submission with invalid or missing data.

The original intent of the blank? method was to check if all the key financial inputs (desired home price, down payment, income, interest rate, and debt payments) are effectively empty/zero, likely to determine if the user has entered any meaningful data yet. This is used in the view to show either a blank slate message or the calculated results.

The fix converts each value to a float using to_f before checking if it's zero. This is safer because:

1. nil.to_f returns 0.0 instead of raising an error
2. It maintains the original intent of treating both nil and zero values as "blank"
3. It handles string inputs gracefully (strings that can't be converted to numbers become 0.0)
4. It preserves the existing behavior for actual numeric values

The change makes the code more resilient while maintaining the same logical behavior that was intended in the original implementation.

Error Details

Summary:

NoMethodError: undefined method 'zero?' for nil (NoMethodError)

    [ desired_home_price, down_payment, annual_pre_tax_income, loan_interest_rate, monthly_debt_payments ].all?(&:zero?)
                                                                                                          ^^^^^

Stacktrace:

app/presenters/tool/presenter/home_affordability_calculator.rb:13
app/presenters/tool/presenter/home_affordability_calculator.rb:13
action_view/helpers/capture_helper.rb:50
action_view/buffers.rb:75
action_view/helpers/capture_helper.rb:50
action_view/helpers/tag_helper.rb:230
action_view/helpers/tag_helper.rb:329
/home/deploy/maybe-marketing-prod/shared/bundle/ruby/3.4.0/gems/turbo-rails-2.0.11/app/helpers/turbo/frames_helper.rb:42
action_view/base.rb:281
action_view/base.rb:281
action_view/template.rb:284
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/template.rb:583
action_view/template.rb:272
action_view/renderer/partial_renderer.rb:252
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/renderer/partial_renderer.rb:246
action_view/renderer/partial_renderer.rb:237
action_view/renderer/renderer.rb:78
action_view/renderer/renderer.rb:49
action_view/helpers/rendering_helper.rb:152
action_view/helpers/capture_helper.rb:50
action_view/buffers.rb:75
action_view/helpers/capture_helper.rb:50
action_view/helpers/capture_helper.rb:176
action_view/base.rb:281
action_view/base.rb:281
action_view/template.rb:284
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/template.rb:583
action_view/template.rb:272
action_view/renderer/template_renderer.rb:66
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/renderer/template_renderer.rb:60
action_view/renderer/template_renderer.rb:76
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/renderer/template_renderer.rb:75
action_view/renderer/template_renderer.rb:59
action_view/renderer/template_renderer.rb:11
action_view/renderer/renderer.rb:58
action_view/renderer/renderer.rb:31
action_view/rendering.rb:136
action_view/base.rb:308
action_view/rendering.rb:135
action_controller/metal/streaming.rb:179
action_view/rendering.rb:122
action_controller/metal/rendering.rb:186
action_controller/metal/renderers.rb:140
abstract_controller/rendering.rb:28
action_controller/metal/rendering.rb:167
action_controller/metal/instrumentation.rb:31
active_support/benchmark.rb:17
action_controller/metal/instrumentation.rb:31
action_controller/metal/instrumentation.rb:100
active_record/railties/controller_runtime.rb:46
action_controller/metal/instrumentation.rb:30
meta_tags/controller_helper.rb:22
action_controller/metal/implicit_render.rb:39
action_controller/metal/basic_implicit_render.rb:9
abstract_controller/base.rb:226
action_controller/metal/rendering.rb:193
abstract_controller/callbacks.rb:261
active_support/callbacks.rb:120
turbo-rails.rb:24
/home/deploy/maybe-marketing-prod/shared/bundle/ruby/3.4.0/gems/turbo-rails-2.0.11/app/controllers/concerns/turbo/request_id_tracking.rb:10
active_support/callbacks.rb:129
action_text/rendering.rb:25
action_text/engine.rb:71
active_support/callbacks.rb:129
active_support/callbacks.rb:129
sentry/rails/controller_transaction.rb:21
sentry/hub.rb:115
sentry/span.rb:237
sentry/hub.rb:113
sentry-ruby.rb:507
sentry/rails/controller_transaction.rb:18
active_support/callbacks.rb:129
active_support/callbacks.rb:140
abstract_controller/callbacks.rb:260
action_controller/metal/rescue.rb:27
action_controller/metal/instrumentation.rb:76
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_controller/metal/instrumentation.rb:75
action_controller/metal/params_wrapper.rb:259
active_record/railties/controller_runtime.rb:39
abstract_controller/base.rb:163
action_view/rendering.rb:40
action_controller/metal.rb:252
action_controller/metal.rb:335
action_dispatch/routing/route_set.rb:67
action_dispatch/routing/route_set.rb:50
action_dispatch/journey/router.rb:53
action_dispatch/journey/router.rb:133
action_dispatch/journey/router.rb:126
action_dispatch/journey/router.rb:126
action_dispatch/journey/router.rb:34
action_dispatch/routing/route_set.rb:908
logtail-rails/error_event.rb:24
logtail-rack/http_events.rb:213
logtail-rack/user_context.rb:74
logtail-rails/session_context.rb:16
logtail-rack/http_context.rb:23
logtail/current_context.rb:120
logtail/current_context.rb:44
logtail-rack/http_context.rb:22
rack/static.rb:161
rack/tempfile_reaper.rb:20
rack/etag.rb:29
rack/conditional_get.rb:31
rack/head.rb:15
action_dispatch/http/permissions_policy.rb:38
action_dispatch/http/content_security_policy.rb:38
rack/session/abstract/id.rb:274
rack/session/abstract/id.rb:268
action_dispatch/middleware/cookies.rb:706
action_dispatch/middleware/callbacks.rb:31
active_support/callbacks.rb:100
action_dispatch/middleware/callbacks.rb:30
sentry/rails/rescued_exception_interceptor.rb:14
action_dispatch/middleware/debug_exceptions.rb:31
sentry/rack/capture_exceptions.rb:30
sentry/hub.rb:269
sentry-ruby.rb:420
sentry/rack/capture_exceptions.rb:21
sentry/hub.rb:59
sentry-ruby.rb:400
sentry/rack/capture_exceptions.rb:20
action_dispatch/middleware/show_exceptions.rb:32
rails/rack/logger.rb:41
rails/rack/logger.rb:29
action_dispatch/middleware/remote_ip.rb:96
action_dispatch/middleware/request_id.rb:34
rack/method_override.rb:28
rack/runtime.rb:24
active_support/cache/strategy/local_cache_middleware.rb:29
action_dispatch/middleware/executor.rb:16
action_dispatch/middleware/static.rb:27
rack/sendfile.rb:114
action_dispatch/middleware/ssl.rb:92
rails/engine.rb:535
puma/configuration.rb:279
puma/request.rb:99
puma/thread_pool.rb:390
puma/request.rb:98
puma/server.rb:472
puma/server.rb:254
puma/thread_pool.rb:167

Tip

You can make revisions or ask questions of Revise.dev by using /revise in any comment or review!

• /revise Add a comment above the method to explain why we're making this change.
• /revise Why did you choose to make this change specifically?

Important

If something doesn’t look right, click to retry this interaction.

Quick links: View in Sentry • View in Revise