Merge pull request #688 from maykinmedia/feature/208-refactor-docker-…

…decorator [#208] Improve docker reload fixture decorator
maykinmedia · Feb 13, 2025 · 9c9bfb4 · 9c9bfb4
2 parents fd8c6b6 + 5f31f50
commit 9c9bfb4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/backend/docs/developers/vcr-tests.rst b/backend/docs/developers/vcr-tests.rst
@@ -23,4 +23,9 @@ To do this, stop the Docker deamon and restart it as follows (more info https://
 
 
 Then the client will be configured using `client = docker.DockerClient(base_url='tcp://127.0.0.1:2375')` instead of
-`client = docker.from_env()`.
+`client = docker.from_env()`.
+
+Environment variables
+=====================
+
+- ``RECORDING_CASSETTES_VCR``: Defaults to ``False``. Set this to ``True`` if you are re-recording the cassettes. 
diff --git a/backend/src/openarchiefbeheer/conf/base.py b/backend/src/openarchiefbeheer/conf/base.py
@@ -415,6 +415,8 @@
 
 WAITING_PERIOD = config("WAITING_PERIOD", 7)
 
+RECORDING_CASSETTES_VCR = config("RECORDING_CASSETTES_VCR", False)
+
 ##############################
 #                            #
 # 3RD PARTY LIBRARY SETTINGS #

diff --git a/backend/src/openarchiefbeheer/utils/utils_decorators.py b/backend/src/openarchiefbeheer/utils/utils_decorators.py
@@ -20,7 +20,7 @@ def decorator(func):
         sudo dockerd -H unix:///var/run/docker.sock -H tcp://127.0.0.1:2375
         ```
         """
-        if settings.ENVIRONMENT == "CI":
+        if not settings.RECORDING_CASSETTES_VCR:
             return func
 
         try: