Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#706] Resutaattype filter - Backend #708

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

SilviaAmAm
Copy link
Collaborator

@SilviaAmAm SilviaAmAm commented Feb 20, 2025

Partly fixes #706

@SilviaAmAm SilviaAmAm changed the title [#706] Resutaattype filter [#706] Resutaattype filter - Backend Feb 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.37%. Comparing base (b10f830) to head (9bd92fb).

Files with missing lines Patch % Lines
backend/src/openarchiefbeheer/zaken/api/views.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
+ Coverage   90.30%   90.37%   +0.06%     
==========================================
  Files         215      215              
  Lines        6357     6377      +20     
  Branches      675      675              
==========================================
+ Hits         5741     5763      +22     
+ Misses        616      614       -2     
Flag Coverage Δ
backend 91.03% <91.30%> (-0.01%) ⬇️
jest 32.71% <0.00%> (ø)
storybook 86.40% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm requested review from svenvandescheur and removed request for svenvandescheur February 20, 2025 11:43
@SilviaAmAm SilviaAmAm marked this pull request as draft February 20, 2025 15:46
@SilviaAmAm SilviaAmAm force-pushed the feature/706-resutaattype-filter branch from 37940da to 22b90d9 Compare February 21, 2025 11:23
This was causing some flakiness
Had to debug some flaky tests and I had to look up this info again for the millionth time. So now I have written it down. Hopefully I will remember that I wrote it down.
@SilviaAmAm SilviaAmAm force-pushed the feature/706-resutaattype-filter branch from 22b90d9 to 9bd92fb Compare February 21, 2025 11:24
@SilviaAmAm SilviaAmAm marked this pull request as ready for review February 21, 2025 11:34
@SilviaAmAm SilviaAmAm merged commit e4ca185 into main Feb 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hoofdzaak, resultaat en afdeling zijn zoekvelden, maar zouden filtervelden moeten zijn.
3 participants