-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a leaflet-measure.css file for finer-tuning of the Measurement… #266
Conversation
…hidden behind page header mbari-org#261 & Adjust the "Look and Feel" of the Row and Form controls input and buttons with CSS. mbari-org#253.
I see in ba8f970 that 13 files were modified with ids added to several elements to adjust various CSS attributes attempting to fix the problem of some elements being hidden by other elements. These are too many changes to approve by simple visual inspection of the code changes. It'll be a few days before I can spin up a test environment for the web page rendering and based on previous experience there is no assurance that I can visually identify correct rendering of all the pages. This approach of adding more CSS attributes to fix problems leads to a lot more code (primarily CSS) that needs to be understood and maintained. Perhaps there is another approach that can fix the problems without adding more CSS code. I confess to not being an expert in CSS, but maybe the layout problems were caused by many changes in the project's CSS in earlier commits like d61b3cf and b66f8fe. I understand that it's a drastic ask, but could all of these changes be reverted, going back to a more vanilla cookiecutter-django project design and then judiciously adding back required changes? |
Mike, I know you are not a fan of CSS. To be honest I am not certain if I am all that comfortable with Django or crispy forms. However, I have spent a considerable amount of time working to understand both and getting CSS to play nicely with them on the project. What you are asking is a significant ask given all of that. I had understood my role in SMDB involved the front end (UI) which involves CSS (love it or hate it) and yours was the backend control code. If you feel my recent changes and use of CSS are not in line with the project’s goals, then I think it might be a good time to sit down with Kevin to discuss how to address these style differences and clarify our project tool usage. He is available tomorrow between 11-12 so we can speak with him together after our discussion of the existing precruise web form in my office at 11. See you then. Karen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments on main PR page.
I will add an issue to address the Responsive View of the Missions Page. Thanks. |
Issue #257. Adding a leaflet-measure.css file for finer-tuning of the Measurement App. Further updates will be added to this file as needed.