Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-restructure #79

Merged
merged 3 commits into from
Feb 2, 2025
Merged

Re-restructure #79

merged 3 commits into from
Feb 2, 2025

Conversation

aecsocket
Copy link
Contributor

Makes some restructuring changes to how nodes are formatted in RON:

  • ty and inner are no longer separate, now we use the ReflectSerializer format and deserialize the type in inner directly
-            ty: "editor_as_a_plugin::MyCustomNode",
-            inner: (),
+            inner: {
+                "editor_as_a_plugin::MyCustomNode": (),
+            },
  • Standardises the naming scheme of node pins to be snake_case

Copy link
Owner

@mbrea-c mbrea-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done! LGTM

@mbrea-c mbrea-c merged commit 12e28ba into mbrea-c:master Feb 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants