-
Notifications
You must be signed in to change notification settings - Fork 6
Indigo · Development Standards
You may create a separate branch for you to develop with. If to do so, the branch name should be indigo-dev-[your_first_name]
(e.g. indigo-dev-lingxi
).
After making changes, you can simply push it into your own branch and make a pull request from your branch to indigo-dev
branch (not main
or frontend-code-base
immediately), and then we are going to merge with them after reviewing and integrating.
If you have any question in creating a branch or a pull request, you can ask Lingxi for help.
If you decide to work on the same branch with others, you have to communicate with them before doing so. Make sure that you will not work on the file that other people are also working on.
IMPORTANT: If you are editing the same file (and probably same lines), it is possible to face some code conflicting between you two.
Every merge from personal branch into indigo-dev
branch needs a code review.
Before it is merged, let Lingxi know and check it to make sure it is okay to merge.
Every PR submitted before 8pm should be reviewed at the same day. Otherwise, the next day.