Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging main #171

Merged
merged 109 commits into from
Feb 13, 2025
Merged

Merging main #171

merged 109 commits into from
Feb 13, 2025

Conversation

aditigopalan
Copy link
Contributor

@aditigopalan aditigopalan commented Feb 13, 2025

No description provided.

Sequencing Level 1 model contains everything needed, so GeoMx Level 1 can be limited to just GeoMx-specific attributes
Sequencing Level 2 model contains everything needed, so GeoMx Level 2 can be limited to just GeoMx-specific attributes
Sequencing Level 3 model contains everything needed, so GeoMx Level 3 can be limited to just GeoMx-specific attributes
Already contained in Sequencing Level 1
Include attributes from shared that capture workflow details
- added DSP Dataset Metadata attribute and added to schema def
- update descriptions to provide better guidance
Add "Metadata" as a file level, to help indicate that the information must be mapped onto a metadata template
CV updates from script
Using schematic 24.12.1
Add attribute GeoMx Imaging AOI Coordinates and update schema definition.

This attribute allows a submitter to identify specific coordinate/mask files to be used with a GeoMx image
Using schematic 24.12.1
Retain Publication Dataset Alias to simplify curation and database updates
Move json to json_schemas and csvs to templates
Add output file handling
Replace Component Key attributes in Collection with Component Table Id attributes, which will be used to log table subsets generated for sharing alongside file Datasets
Using schematic v24.12.1
Add data type qualifier to description
Added DOI attributes for Dataset View, Tool View, and Educational Resource models
Also added Keys to Educational Resource, but retained tool and dataset link attributes, in case the ed res uses resources from outside of Synapse
For mapping and conversion
Bankso and others added 28 commits February 7, 2025 17:07
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
Align valid values from CDS v5.0.4
These are stored in visium-specific folders
Remove unneeded attributes, covered by File View template
These values live in sequencing-specific folders, CSVs in shared were redundant
Equivalent to tissueOrganOriginCDS.csv, so I deleted this file and replaced mapping reference with reference to tissueOrganOriginCDS.csv
Align mappings with current set of valid values
Added Biospecimen Treatment Response, Incidence Type
Added valid values for Acquisition method
Removed Biospecimen Pathology
Updated by update valid values script
Updated by update valid values script
Updated by update valid values script
Updated by update valid values script
Updated by update valid values script
Updated by update valid values script; Moved attributes NGS Raw Reads and NGS Unique Bases  from sequencing level 2 to sequencing level 1 and added to level 1 model definition. These are requested by CDS model
Updated by update valid values script; removed attributes now in sequencing level 1
Updated by update valid values script
Updated by update valid values script
generated via schematic 24.12.1
This will be maintained locally until a clear need for storage in the repo is identified
mc2_qc.model.csv is a copy of the current mc2.model.csv, with cross-manifest validation rules removed, so it can be used for final validation of UNION table manifests
mc2_qc.model.jsonld is the schematic converted JSON-LD, using schematic 24.12.1
Pre-release revisions and alignment with CDS v5.0.4
@aditigopalan aditigopalan requested a review from Bankso as a code owner February 13, 2025 18:49
@aditigopalan aditigopalan merged commit 52bb545 into feat-add-sync-action Feb 13, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants