Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acrobatics damage calculations #5088

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

Ineusia
Copy link
Contributor

@Ineusia Ineusia commented Sep 20, 2024

Currently, acrobatics does it's damage calculates pre-vanilla damage reductions which leads to a non-fatal fall being considered fatal.

This leads to armored players never procing Roll or Graceful Landing when they infact should, as their fall damage was not fatal.

This change uses the getFinalDamage() method instead of getDamage() method which will use the post-vanilla reduction damage calculation to calculate fatality as well as mcMMO's further reductions.

Using setDamage would re-trigger vanilla damage reductions and would result in a double-reduction, both pre and post mcMMO calculations, so we instead setDamage to 0 from this fall and set a new damage with the DamageType of MAGIC which bypasses resistances.

This is perfectly fine because vanilla reductions are already factored into the fall before mcMMO does any modification, and the server will never see a death from "magic" since Roll will not run any modifications should the fall be fatal.

@nossr50 nossr50 merged commit 1c08cac into mcMMO-Dev:master Sep 20, 2024
1 check passed
@nossr50
Copy link
Member

nossr50 commented Sep 20, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants