Fix slime spawner exploit #5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nossr50
requested changes
Sep 20, 2024
nossr50
reviewed
Sep 28, 2024
| @@ -57,6 +58,7 @@ public class EntityListener implements Listener { | |||
| * check if a {@link Player} has a {@link Trident} enchanted with "Piercing". | |||
| */ | |||
| private final NamespacedKey piercingEnchantment = NamespacedKey.minecraft("piercing"); | |||
| private final List<EntityType> transformableEntities = Arrays.asList(EntityType.SLIME, EntityType.MAGMA_CUBE); | |||
There was a problem hiding this comment.
This should be static as well, I'll make the change after I merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, slime/magma cube meta gets cleaned at death which fires before the Transform event. This means the smaller slimes/magma cubes from a spawner slime will not have tags carry over, allowing players to farm combat skills from spawned mobs.
This PR moves cleaning for Slimes/Magma Cubes to after the transform event, which we know means the slime is dead anyways, so it's fine to clean them there.