Add event for players taming an entity #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nossr50
reviewed
Jan 25, 2025
| * @throws IllegalArgumentException if xpGained is NaN or infinite. | ||
| */ | ||
| public void setXpGained(float xpGained) { | ||
| Preconditions.checkArgument(Float.isFinite(xpGained), "new gained xp must be a number"); |
There was a problem hiding this comment.
You shouldn't need this check since you are passing in a primitive type, instead it would be a good idea to make sure the float is a positive number
There was a problem hiding this comment.
I've added a check for positive numbers, but the isFinite one is still useful because a primitive float can be NaN/infinite
There was a problem hiding this comment.
@Warriorrrr Thank you for that info, it seems you are correct on this, my mistake!
nossr50
requested changes
Jan 25, 2025
src/main/java/com/gmail/nossr50/events/skills/taming/McMMOPlayerTameEntityEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/nossr50/events/skills/taming/McMMOPlayerTameEntityEvent.java
Outdated
Show resolved
Hide resolved
nossr50
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an event that allows plugins to modify xp gain for taming specific entities, or to cancel the xp gain outright.