-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DISCO-1604: Protocol support, salt class, metalot structure fix and logging #167
Conversation
…tion and add NullHandler to avoid errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable, but the get_all_protocols
endpoint naming compared to the contents of the response is confusing to me. Awaiting your response before approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the nit about an unused ACAS_LSTHING
constant, this LGTM. Let's spin off the refactor to a separate PR, especially since this code is already tested through the migration.
Description
Protocol
objectRelated Issue
DISCO-1604
How Has This Been Tested?
Added acasclient tests for protocol changes
Verified duplicate login issue was fixed when using an external library.