Added new dhparams.pem #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmcneil86043 Does that mean you tried it out and it works? |
|
@brianbolt No, I thought I had to approve this in order to get a docker image to test |
|
No, we don't have any CI/CD on this repo to build docker images so I thought maybe your LGTM was because you tested with the docker image that @philippcheung said he pushed. Should be ready to test now if you get a chance. |
brianbolt
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new dhparams.pem
Description
Original error was:
kill -l [exitstatus]
2022/09/22 20:17:58 [emerg] 78#78: SSL_CTX_set_tmp_dh("/etc/ssl/private/dhparams.pem") failed (SSL: error:1408518A:SSL routines:ssl3_ctx_ctrl:dh key too small)
nginx: [emerg] SSL_CTX_set_tmp_dh("/etc/ssl/private/dhparams.pem") failed (SSL: error:1408518A:SSL routines:ssl3_ctx_ctrl:dh key too small)
Solution was generate a new dhparam.pem
openssl dhparam 2048 -out dhparam.pem
and replace existing dhparam.pem file
Related Issue
How Has This Been Tested?