Create remaining configuration settings #16 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcspronko
requested changes
Aug 29, 2019
admin/Source/Currencies.php
Outdated
| use Magento\Framework\Data\OptionSourceInterface; | ||
|
|
||
| /** | ||
| * Class ConnectionType |
| */ | ||
| class Currencies implements OptionSourceInterface | ||
| { | ||
| const USD = 'USD'; |
There was a problem hiding this comment.
Please move these settings to the config.xml/di.xml file
admin/etc/adminhtml/system.xml
Outdated
| @@ -36,6 +36,11 @@ | |||
| <source_model>Pronko\LiqPayAdmin\Source\ConnectionType</source_model> | |||
| <config_path>payment/pronko_liqpay/connection_type</config_path> | |||
| </field> | |||
| <field id="payment_action" translate="label" type="select" sortOrder="30" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1"> | |||
| <label>Payment Action</label> | |||
| <source_model>Magento\AuthorizenetAcceptjs\Model\Adminhtml\Source\PaymentAction</source_model> | |||
There was a problem hiding this comment.
Payment Action should be created in the Pronko_LiqPayAdmin module
admin/etc/adminhtml/system.xml
Outdated
| @@ -36,6 +36,11 @@ | |||
| <source_model>Pronko\LiqPayAdmin\Source\ConnectionType</source_model> | |||
| <config_path>payment/pronko_liqpay/connection_type</config_path> | |||
| </field> | |||
| <field id="payment_action" translate="label" type="select" sortOrder="30" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1"> | |||
There was a problem hiding this comment.
ShowInStore should be set to 1
admin/etc/adminhtml/system.xml
Outdated
| <config_path>payment/pronko_liqpay/maximum_order_total</config_path> | ||
| </field> | ||
| <field id="sort_order" translate="label" type="text" sortOrder="30" showInDefault="1" showInWebsite="1" showInStore="1"> | ||
| <label>Sort Total</label> |
admin/etc/config.xml
Outdated
| </pronko_liqpay_section> | ||
| </payment> | ||
| </default> | ||
| </config> |
admin/etc/module.xml
Outdated
| <module name="Pronko_LiqPayAdmin" /> | ||
| <module name="Pronko_LiqPayAdmin"> | ||
| <sequence> | ||
| <module name="Magento_Sales"/> |
There was a problem hiding this comment.
I don't think we should add sequence for Sales module
card-admin/Model/Source/Cctype.php
Outdated
| */ | ||
| public function getAllowedTypes() | ||
| { | ||
| return ['VI', 'MC', 'AE', 'DI', 'JCB', 'DN']; |
There was a problem hiding this comment.
Please see cctypes in the LiqPayCardGateway/etc/config.xml.
There are only 2 currencies supported.
card-admin/etc/adminhtml/system.xml
Outdated
| <group id="pronko_liqpay" translate="label" type="text" sortOrder="100" showInDefault="1" showInWebsite="1" showInStore="1"> | ||
| <label>LiqPay</label> | ||
| <fieldset_css>complex</fieldset_css> | ||
| <attribute type="displayIn">other_payment_methods</attribute> |
There was a problem hiding this comment.
attribute node can be removed.
There was a problem hiding this comment.
After discussion we decide to leave them for now.
card-admin/etc/adminhtml/system.xml
Outdated
| <label>Card Payment</label> | ||
| <attribute type="expanded">1</attribute> | ||
| <frontend_model>Magento\Config\Block\System\Config\Form\Fieldset</frontend_model> | ||
| <field id="cctypes" translate="label" type="multiselect" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1"> |
mcspronko
reviewed
Aug 29, 2019
admin/etc/adminhtml/system.xml
Outdated
| </field> | ||
| <field id="order_status" translate="label" type="select" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1"> | ||
| <label>New Order Status</label> | ||
| <source_model>Magento\Sales\Model\Config\Source\Order\Status\Processing</source_model> |
There was a problem hiding this comment.
Please use Magento\Sales\Model\Config\Source\Order\Status
|
@nikolalardev hi there, any news on this pull request? Do you need help with this? please let us know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: Create remaining configuration settings #16