Special-case sync return from async call and preserve last error #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tormod Volden <[email protected]>
usb_control_msg() returns various error codes, so map these to Win32 errors that can be read out by calling functions. Signed-off-by: Tormod Volden <[email protected]>
If DeviceIoControl() succeeds synchronously it isn't advised to call GetOverlappedResult() [1]. In practive it seems like GetOverlappedResult() works in any case, but all Microsoft examples treat the synchronous completion case separately. Also preserve the Win32 last error from the failing call since a failing CloseHandle() might clobber it. [1] https://learn.microsoft.com/en-GB/troubleshoot/windows/win32/asynchronous-disk-io-synchronous Signed-off-by: Tormod Volden <[email protected]>
|
Hi Travis, I think this PR is safe to merge. Please review when you got the time. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few things I noticed while reviewing the libusb0 backend code. They are not tested and do not fix any reported issues, but I believe they make the code more correct and will give better error diagnosis.