Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Prompt deserialization defaults. #6

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Fix Prompt deserialization defaults. #6

merged 2 commits into from
Oct 12, 2024

Conversation

mdegans
Copy link
Owner

@mdegans mdegans commented Oct 12, 2024

Prompt now deserializes from an empty map or with fields missing

Prompt now deserializes from an empty map or with fields missing,
@mdegans
Copy link
Owner Author

mdegans commented Oct 12, 2024

There may be other structs where this is desirable, but for the moment I am only adding what I need for my own use. If anybody else wants serde(default) on a thing, please file an Issue or send a PR.

Writing the cach to disk took minutes while the actual tests take seconds, so there isn't a point.
@mdegans mdegans merged commit a2a1135 into main Oct 12, 2024
3 checks passed
@mdegans mdegans deleted the dev branch October 12, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant