Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force reference to be reloaded when params have changed #45

Closed
wants to merge 1 commit into from
Closed

fix: force reference to be reloaded when params have changed #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addon/mixins/model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export default Mixin.create({
* @param propertyName Relationship property name
* @returns {Ember.RSVP.Promise}
*/
reloadRelationship: function (propertyName) {
reloadRelationship: function (propertyName, forceReload) {
//find out what kind of relationship this is
const relationship = this.relationshipFor(propertyName);
const isHasMany = relationship && relationship.kind === 'hasMany';
Expand All @@ -99,7 +99,7 @@ export default Mixin.create({
//run.next, so that aborted promise gets rejected before starting another
next(this, function () {
const isLoaded = reference.value() !== null;
if (isLoaded) {
if (isLoaded || forceReload) {
resolve(reference.reload());
} else {
//isLoaded is false when the last query resulted in an error, so if this load
Expand Down