Skip to content

Commit

Permalink
Merge branch 'develop' into qual/phan.2024.2.4
Browse files Browse the repository at this point in the history
  • Loading branch information
eldy authored Feb 4, 2025
2 parents 1a41838 + efeeab4 commit 87e1398
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions htdocs/core/ajax/ajaxdirpreview.php
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,15 @@
}
} else {
// When no an ajax call (include from other file)
/*

Check warning on line 99 in htdocs/core/ajax/ajaxdirpreview.php

View workflow job for this annotation

GitHub Actions / phan / Run phan

ajaxdirpreview.php: PhanPluginPHPDocInWrongComment: Saw possible phpdoc annotation in ordinary block comment "/*\n\t * @var string $module\n\t */". PHPDoc comments should start with "/**" (followed by whitespace), not "/*"
* @var string $module
*/
'
@phan-var-force int $section
@phan-var-force string $module
@phan-var-force string $showonrightsize
';

$rootdirfordoc = $conf->ecm->dir_output;

$ecmdir = new EcmDirectory($db);
Expand Down
2 changes: 1 addition & 1 deletion htdocs/core/class/html.form.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -9451,7 +9451,7 @@ public static function multiselectarray($htmlname, $array, $selected = array(),
* @param string $htmlname Name of HTML field
* @param array<string,array{label:string,checked?:string,enabled?:string,type?:string,langfile?:string,position?:int,help?:string}> $array Array with array of fields we could show. This array may be modified according to setup of user.
* @param string $varpage Id of context for page. Can be set by caller with $varpage=(empty($contextpage)?$_SERVER["PHP_SELF"]:$contextpage);
* @param string $pos Position colon on liste value 'left' or '' (meaning 'right').
* @param string $pos Position of the colon in list: 'left' or '' (meaning 'right').
* @return string HTML multiselect string
* @see selectarray()
*/
Expand Down
2 changes: 1 addition & 1 deletion htdocs/modulebuilder/template/myobject_list.php
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@
}

$varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, $conf->main_checkbox_left_column); // This also change content of $arrayfields with user setup
$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, $conf->main_checkbox_left_column ? 'left' : ''); // This also change content of $arrayfields with user setup
$selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
$selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');

Expand Down
2 changes: 1 addition & 1 deletion htdocs/user/group/list.php
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@
}

$varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, $conf->main_checkbox_left_column); // This also change content of $arrayfields with user setup
$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, $conf->main_checkbox_left_column ? 'left' : ''); // This also change content of $arrayfields with user setup
$selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
$selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');

Expand Down

0 comments on commit 87e1398

Please sign in to comment.