QUAL Ignore some phan annotations

mdeweerd · Dec 6, 2023 · bc36e61 · bc36e61
1 parent 816fa86
commit bc36e61
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/phan.yml b/.github/workflows/phan.yml
@@ -15,7 +15,7 @@ jobs:
           tools: cs2pr,phan
       - name: Run Phan analysis
         run: |
-          phan --quick -k .phan/config.php -B .phan/baseline.txt --analyze-twice --minimum-target-php-version 7.1 --output-mode=checkstyle -o _phan.xml
+          phan --quick -k .phan/config.php -B .phan/baseline.txt --analyze-twice --minimum-target-php-version 7.0 --output-mode=checkstyle -o _phan.xml
       - name: Add results to PR
         if: ${{ always() }}
         run: |

diff --git a/.phan/config.php b/.phan/config.php
@@ -44,7 +44,6 @@
 	//	should be added to the `directory_list` as
 	//	to `exclude_analysis_directory_list`.
 	"exclude_analysis_directory_list" => [
-		'.',
 		'htdocs/includes/',
 		'htdocs/core/class/lessc.class.php', // External library
 

diff --git a/htdocs/adherents/class/adherent.class.php b/htdocs/adherents/class/adherent.class.php
@@ -1827,6 +1827,7 @@ public function subscriptionComplementaryActions($subscriptionid, $option, $acco
 					$vattouse = get_default_tva($mysoc, $mysoc, $idprodsubscription);
 				}
 				//print xx".$vattouse." - ".$mysoc." - ".$customer;exit;
+				// @phan-suppress-next-line PhanPluginSuspiciousParamOrder
 				$result = $invoice->addline($label, 0, 1, $vattouse, 0, 0, $idprodsubscription, 0, $datesubscription, '', 0, 0, '', 'TTC', $amount, 1);
 				if ($result <= 0) {
 					$this->error = $invoice->error;

diff --git a/htdocs/admin/mails_emailing.php b/htdocs/admin/mails_emailing.php
@@ -450,6 +450,7 @@ function change_smtp_auth_method() {
 
 		// SuperAdministrator access only
 		if (!isModEnabled('multicompany')  || ($user->admin && !$user->entity)) {
+			// @phan-suppress-next-line PhanPluginSuspiciousParamOrder
 			print $form->selectarray('MAIN_MAIL_SMTPS_OAUTH_SERVICE_EMAILING', $oauthservices, $conf->global->MAIN_MAIL_SMTPS_OAUTH_SERVICE_EMAILING);
 		} else {
 			$text = $oauthservices[getDolGlobalString('MAIN_MAIL_SMTPS_OAUTH_SERVICE_EMAILING')];