Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toGridLengthHelper: fix double "fr" on "minmax" #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PedroHLC
Copy link

Expected behavior

fillPortion 128 |> minimum 1 should create a grid column with minmax(1px, 128fr).

Current behavior

CSS was generating something like:

.grid-rows-auto-cols-min1128fr-88fr-140fr-142fr-216fr-space-x-0px-space-y-0px {
  grid-template-columns: minmax(1px, 128frfr) 88fr 140fr 142fr 216fr;
  # etc etc etc
}

The frfr breaks the entire rule. And the browser goes wild.

Suggested fix

Remove the repetition, s/frfr/fr/.

There are no tests covering grid, so I also didn't add one for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant