Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data for html.elements.a.attributionsourceid #21896

Merged
merged 3 commits into from
May 29, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Jan 10, 2024

Summary

the attributionSourceId property can also be used as a html attribute

using data from api.HTMLAnchorElement.attributionSourceId and assume its data is correct, see #17650

see also the spec https://privacycg.github.io/private-click-measurement/

commits are WebKit/WebKit@1089deb#diff-563aee51175c2cff693a258f0cb397e98989afe3fb1cb3c203df1774f6eb9c2d and later WebKit/WebKit@f4e94ae

in commits, the attributionsourceid is renamed from adcampaignid, maybe this can be an altername?

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jan 10, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 10, 2024 17:55
@queengooborg queengooborg added the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Jan 12, 2024
@queengooborg
Copy link
Contributor

We're not sure if we want to keep this data in BCD yet and are discussing potential removal in #21194. Marking as "not ready".

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this, it matches the info we have in api.HTMLAnchorElement.attributionSourceId

@Elchi3 Elchi3 removed the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label May 29, 2024
@Elchi3 Elchi3 merged commit 27b80f1 into mdn:main May 29, 2024
6 checks passed
@skyclouds2001 skyclouds2001 deleted the html.elements.a.attributionsourceid branch May 29, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants