Fix bcd key for HTMLDialogElement #38288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2025-02-24 16:41:21) |
skyclouds2001
requested review from
sideshowbarker
and removed request for
a team
hamishwillee
requested changes
Feb 23, 2025
There was a problem hiding this comment.
@skyclouds2001 No, let's not do this. Instead can you please remove just api.HTMLDialogElement.requestClose, which is a duplicate.
These new events are relevant to the use of the dialog and would otherwise not be surfaced to to readers. For pragmatic reasons we choose not to duplicate the actual documentation for inherited elements but there no cost to us in doing so for this very relevant compatibility information.
EDIT: Or to put it another way, the consistency in this case does not help us or our readers.
skyclouds2001
commented
Feb 24, 2025
github-actions
bot
added
size/xs
hamishwillee
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for consistent, only api.HTMLDialogElement should be listed
Motivation
Additional details
Related issues and pull requests