Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @@notation from generator prototype diagrams #18

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Remove @@notation from generator prototype diagrams #18

merged 2 commits into from
Jul 16, 2024

Conversation

Josh-Cena
Copy link
Member

Part of mdn/mdn#562.

@bsmth Are we supposed to optimize SVGs here? I don't know how

@Josh-Cena Josh-Cena requested a review from a team as a code owner July 15, 2024 03:04
@Josh-Cena Josh-Cena requested a review from bsmth July 15, 2024 03:04
@bsmth
Copy link
Member

bsmth commented Jul 16, 2024

We can add svgo in this repo, I've been using https://jakearchibald.github.io/svgomg/, but there's no shared config available for that so it's a manual step for now.

bsmth
bsmth approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bsmth bsmth merged commit d7f75ce into mdn:main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @bsmth