Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS tools from CSS sidebar #10028

Closed
wants to merge 1 commit into from
Closed

Remove CSS tools from CSS sidebar #10028

wants to merge 1 commit into from

Conversation

estelle
Copy link
Member

@estelle estelle commented Nov 14, 2023

The four tools aren't maintained, responsive, or necessary, and some don't work. We shouldn't be hilighting them until they're fixed.

see:

If we think we are going to fix these tools soon, we could just omit the HTML list and keep the translations.

The four tools aren't maintained, responsive, or necessary, and some don't work. We shouldn't be hilighting them until they're fixed.

see:
* https://github.com/mdn/content/issues/21987 
(* mdn#5392
@estelle estelle requested a review from a team as a code owner November 14, 2023 23:17
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Nov 14, 2023
@caugner
Copy link
Contributor

caugner commented Nov 15, 2023

Hi @estelle, 👋

Thank you for taking the time to open this PR. I just discussed your proposed changes internally with the content team and we agreed that we want to keep the links to the CSS tools in the sidebar, even if they may currently have limitations or bugs. We're accepting PRs from the community to resolve these issues.

So I'm going ahead and close this PR.

Thank you for your understanding. 🙏

PS: Please use and fill out the pull request template when you open PRs in yari, and consider opening an issue first (although in this case it was fine to open a PR directly, since the effort was probably low).

@caugner caugner closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants