Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mint fee #102

Merged
merged 8 commits into from
May 7, 2024
Merged

feat: add mint fee #102

merged 8 commits into from
May 7, 2024

Conversation

channing-magiceden
Copy link
Contributor

@channing-magiceden channing-magiceden commented Dec 22, 2023

  • Besides price, add optional mint fee
  • Mint fee goes to dedicated address when withdraw or withdrawERC20 is invoked
  • Support both ETH and ERC20 payment

@channing-magiceden channing-magiceden marked this pull request as ready for review December 22, 2023 04:26
contracts/ERC721M.sol Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (c23f7fb) to head (57e2205).
Report is 1 commits behind head on main.

❗ Current head 57e2205 differs from pull request most recent head 8c02c18. Consider uploading reports for the commit 8c02c18 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   92.92%   95.02%   +2.09%     
==========================================
  Files           7        7              
  Lines         396      402       +6     
  Branches      112      114       +2     
==========================================
+ Hits          368      382      +14     
+ Misses         28       20       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contracts/ERC721CM.sol Outdated Show resolved Hide resolved
contracts/ERC721CM.sol Outdated Show resolved Hide resolved
@channing-magiceden channing-magiceden merged commit fc0d3e2 into main May 7, 2024
2 checks passed
@channing-magiceden channing-magiceden deleted the channing/mint-fee branch May 7, 2024 23:22
channing-magiceden added a commit that referenced this pull request May 7, 2024
channing-magiceden added a commit that referenced this pull request May 7, 2024
@channing-magiceden channing-magiceden restored the channing/mint-fee branch May 7, 2024 23:32
@channing-magiceden channing-magiceden mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants