Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gasprice + gaslimit override params #117

Merged

Conversation

magicfish23
Copy link
Contributor

@magicfish23 magicfish23 commented Mar 6, 2024

Summary

Added gasprice + gaslimit override params to the following commands:

  • deploy
  • setStages
  • ownerMint
  • setBaseURI

Updated the estimateGas util with extra confirmations to safeguard against accidental overrides and wasting money on gas.
image

Testing

Starting - Wallet Balance:

image

Normal call (no override gaspricegwei):

Command:
npx hardhat --network polygon deploy --name ERC721CM --symbol ERC721CMR2 --maxsupply 1000 --erc2198royaltyreceiver 0xa6da3705F53B516078AF138Bd99eF8708436981D --erc2198royaltyfeenumerator 500
Pre-run output:
image

Tx: 0x0649699cde118acd375d00317dd03a401044e92a75cbd02e5ae0afb146242773
Contract: 0x5f5B9c37ef920B349eCF100aBFf9AE3BEE4c6792
Actual output:
image

Updated call (using override gaspricegwei):

Command:
npx hardhat --network polygon deploy --name ERC721CM --symbol ERC721CMR2 --maxsupply 1000 --erc2198royaltyreceiver 0xa6da3705F53B516078AF138Bd99eF8708436981D --erc2198royaltyfeenumerator 500 --gaspricegwei 200 --gaslimit 5000000
Pre-run output:
image

Tx: 0x5dbb9f648cd3315f8effc40bfd8e8d3814bb3f632d91b5ae2af2c3a3db2ba093
Contract: 0xF038BBF62F05DB95e2f4a353B056Bc51F78B461f
Actual output:
image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.36%. Comparing base (0cf4bd5) to head (f79167b).

❗ Current head f79167b differs from pull request most recent head ced1c9e. Consider uploading reports for the commit ced1c9e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   70.36%   70.36%           
=======================================
  Files          29       29           
  Lines        1164     1164           
  Branches      317      317           
=======================================
  Hits          819      819           
  Misses        344      344           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@channing-magiceden channing-magiceden merged commit 3fe8714 into me-foundation:main Mar 7, 2024
2 checks passed
@magicfish23 magicfish23 deleted the fish/add-gas-param branch March 7, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants