Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC721MPausable #96

Merged
merged 2 commits into from
Oct 19, 2023
Merged

ERC721MPausable #96

merged 2 commits into from
Oct 19, 2023

Conversation

Henry-MagicEden
Copy link
Contributor

@Henry-MagicEden Henry-MagicEden commented Oct 19, 2023 •
edited
Loading

  • This extends ERC721M to be pausable, allowing the contract owner to pause/unpause trading/transfers when they want
  • Also adds a version with the Operator Filterer
  • Add tests and deploy scripts for both
  • Refactor deploy logic a bit to be more readable across the various contracts

Additionally deployed the contract and manually tested pause/unpause with transferFrom and safeTransferFrom to make sure behavior was as expected (i.e. transfers would fail simulations if the contract was paused)

  • Confirmed only contract owner can pause/unpause

NOTE: pause does not affect minting - even if the contract is paused, minting can still proceed

@Henry-MagicEden Henry-MagicEden merged commit 01952c8 into main Oct 19, 2023
2 checks passed
@Henry-MagicEden Henry-MagicEden deleted the henry/erc721m-pausable branch October 19, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mi-yu mi-yu mi-yu approved these changes

@channing-magiceden channing-magiceden channing-magiceden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Henry-MagicEden @mi-yu @channing-magiceden