Don't allow invalid window size when window scale is disabled #187
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I noticed the ESP crashing and tried to investigate the issue to the best of my abilities. This was happening multiple times per 10 minutes, and the ESP restarting every single time. I was shown this backtrace:
I was able to track down the exact assert that was being triggered.
This was the assert being triggered and this was the configured option for
LWIP_WND_SCALE
.Since I didn't know more about the error as I wasn't able to track down how exactly this was caused, I decided to add a check in the function AsyncTCP was handling. You can check the commit for the changes.
This is most likely just a temporary fix until somebody investigates this matter to identify the root issue, but for now it should do. Please point out any issues!