fix: puck context missing from preview render #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@4leite is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
chrisvxd
requested changes
Mar 25, 2024
| export function Render< | ||
| UserConfig extends Config<any, any, any> = Config<any, any, any> | ||
| >({ config, data }: { config: UserConfig; data: Data }) { | ||
| export function Render<UserConfig extends Config = Config>({ |
There was a problem hiding this comment.
The problem is it widens the type (effectively returning any) which is probably what fixed your issue, but it means that the issue below snuck in because it wasn't strongly typed any more.
| @@ -27,7 +37,7 @@ export const Preview = ({ id = "puck-preview" }: { id?: string }) => { | |||
| }} | |||
| style={{ zoom: disableZoom ? 1 : 0.75 }} | |||
| > | |||
| <Page dispatch={dispatch} state={state} {...rootProps}> | |||
| <Page {...rootProps}> | |||
There was a problem hiding this comment.
dispatch and state were kept here to retain backwards compatibility with plugins from v0.12.0, before it was changed in v0.13.0.
I think I'd rather retain these for now, but we should probably mark them as // DEPRECATED so we remember to pull them out during a breaking change release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.