Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export frames as video #1471

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

shaik-zeeshan
Copy link
Contributor

/claim #1407
related #1407

Screen.Recording.2025-02-24.at.7.44.20.PM.1.mp4

Copy link

vercel bot commented Feb 24, 2025

Someone is attempting to deploy a commit to the louis030195's projects Team on Vercel.

A member of the Team first needs to authorize it.

@shaik-zeeshan
Copy link
Contributor Author

I have some doubts about adding this to search pipe.

should the export button be shown only when the selected items are all ocr content-type?
what if user has selected items that have all the three types(audio, ui, ocr)?

@louis030195
Copy link
Collaborator

okay maybe just rewind then yeah

not sure i understand where the video goes though? should be obvious, like https://screen.studio/ or https://cap.so/

@shaik-zeeshan
Copy link
Contributor Author

I have added video saving like cap.so, giving user option where they want to save the video

Screen.Recording.2025-02-27.at.5.51.59.PM.1.mp4

const { writeFile } = tauri.fs;

const filePath = await save({
filters: [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, did not know we could do that with tauri :D

@louis030195
Copy link
Collaborator

louis030195 commented Feb 27, 2025

nice

works

just last thing, there is toast error that shows up every time at the end of the export

https://cap.so/s/sd3mdxts7m72scn

@shaik-zeeshan
Copy link
Contributor Author

just last thing, there is toast error that shows up every time at the end of the export

https://cap.so/s/sd3mdxts7m72scn

looking into this

@shaik-zeeshan
Copy link
Contributor Author

shaik-zeeshan commented Feb 27, 2025

fixed the error toast appear at end of the export

the error you see in console log, is only happening in safari browser client. which seem to be a bug

https://stackoverflow.com/questions/78880146/why-is-closing-a-websocket-in-safari-giving-me-an-error-about-not-being-connecte

@shaik-zeeshan
Copy link
Contributor Author

shaik-zeeshan commented Mar 1, 2025

@louis030195 you can merge this. error toast is not appearing at the end of export

Also let me know about adding tauri APIs in node js sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants