Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release-app.yml #1514

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

divanshu-go
Copy link
Contributor

@divanshu-go divanshu-go commented Mar 1, 2025

@louis030195 Is there any specific reason behind using a old version of bun

updates bun version
Copy link

vercel bot commented Mar 1, 2025

@divanshu-go is attempting to deploy a commit to the louis030195's projects Team on Vercel.

A member of the Team first needs to authorize it.

@louis030195
Copy link
Collaborator

because it works

did you test this?

did you build and run on 3 OS and test all edge cases of the CLI and app?

@divanshu-go
Copy link
Contributor Author

@louis030195 let's just not take the effort to update it. We can still fix linux build ,

@divanshu-go
Copy link
Contributor Author

divanshu-go commented Mar 1, 2025

@louis030195 I reverted it and also wanted to tell that if we don't use bun install script then the build is successful cause that script was redundant

@divanshu-go
Copy link
Contributor Author

I tested it on my repository and didn't used that script for installing bun and it compiled successful

@divanshu-go
Copy link
Contributor Author

You can download the Appimage and see logs of successful build here
https://github.com/divanshu-go/test/actions/runs/13406619955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants