Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#586): allow self signed certs by default for localhost-like hosts #585

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Nov 9, 2023

Description

--accept-self-signed-certs is just too long

#586

Code review items

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or integration tests where appropriate
  • Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan
Copy link
Member Author

Hi @jkuester . Please let me know what you think about this. I'm just so lazy to type this all the time locally.

Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Honestly, though, I am not sure when I would use this functionality. Basically anytime I am running against localhost, I am using --local and just hitting the http port....

@dianabarsan
Copy link
Member Author

I am always running localhost on a different port and I often upload to a local docker-compose full deployment.

@dianabarsan dianabarsan marked this pull request as ready for review November 15, 2023 12:09
@dianabarsan dianabarsan changed the title chore: allow self signed certs by default for localhost-like hosts chore(#586): allow self signed certs by default for localhost-like hosts Nov 15, 2023
@dianabarsan dianabarsan merged commit 0a10a41 into main Nov 15, 2023
12 checks passed
@dianabarsan dianabarsan deleted the auto-insecure-for-localhost branch November 15, 2023 12:11
@medic-ci
Copy link
Collaborator

medic-ci commented Dec 6, 2023

🎉 This PR is included in version 3.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants