feat(#425): E2E test actions #620
Conversation
…running the docker helper script
There was a problem hiding this comment.
Thank you for adding this test @m5r, it looks great ⭐
Just one thing, I didn't find a section in cht-docs that was related to cht-conf, only the README file, I don't know if this was already discussed at some point and we decided to manage the cht-conf documentation outside the cht-docs 🤷♀️ but I think that it will be important to add a section about these e2e tests (in the README file or maybe create a new section in cht-docs) to talk about how can we run them (npm run test-e2e) and maybe about the possible errors that we can find.
For example I had the same error that Josh mention here, luckily I read that comment before trying to execute the tests 😅 , but then I had a error because my CHT server was never up, and I had to increase the timeout value to 100_000 to be able to run it locally.
We can create something similar (but smaller) to the tests specification for cht-core -> Automated Tests
…ing too long to be ready
|
@tatilepizs excellent idea! First, I've added logs and increased the timeout to 120 seconds. This should be enough as it rarely takes more than 60 seconds in the CI to spin up an instance. cht-core's API tests have a 200 second timeout but I don't think we need to reach for that high timeout at this stage. And finally to answer your question, I don't know either why cht-docs doesn't have much covering cht-conf.. |
This is both a question and an answer ;) It's not been documented because people keep asking the question!! If either of you are interested in starting docs on this, possibly with a first step of creating a docs page and replacing the enire readme with a "see docs site!" link, that'd be great! cc @esthermmoturi & @nsitaula |
|
😅 I can help with that. I am going to create a PR to move the README file to the docs. thanks @mrjones-plip And thanks @m5r for the improvements and the section in the README file 🌟 |
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@m5r NB this should have been a |
|
My bad, thanks @garethbowen for pointing out the correct commit type, I'll keep these guidelines (that's the convention semantic-release follows) in mind for future PRs |
Description
#425
This PR adds a first E2E test covering the
compile-app-settingsandupload-app-settingsactions. Tests are run against an actual CHT instance using CHT Docker helper and are run automatically in the CI.The containers the CI runs with cannot resolve
local-ip.medicmobile.orgeven though they can resolve127-0-0-1.local-ip.medic.org🤔 (related medic-infrastructure issue) so the E2E tests are running a slightly modified docker helper script to force DNS resolution. It's a temporary band-aid that should be removed as soon as the DNS issue is fixed.Code review items
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.