chore: update Dockerfile to be based on the Node 20 image #630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we are supporting Node 20, we can bump the version of Node used in the Dockerfile. The only impact this had is that the newer Python package is now requiring we install pyxform into a virtual environment.
One solution would be to just run the
pip install
with the--break-system-packages
flag which should be fine in a simple Docker image like this since the whole point of the containerization is that we don't have competing dependency stacks.That being said, after doing some reading I have instead opted for actually using a virtual environment here. It was not too much trouble and it felt more future-proof (and less janky).
Testing
We do not have any automated testing around the Dockerfile, but you can manually test its functionality with the following steps:
docker build -t medicmobile/cht-app-ide .
compile-forms
since that is what will use the pyxform binaries.Code review items
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.