Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make encounter requests idempotent #148

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat: make encounter requests idempotent #148

merged 2 commits into from
Nov 8, 2024

Conversation

njuguna-n
Copy link

Description

Make Encounter resource requests idempotent by making use of the system identifier

closes https://github.com/medic/config-gandaki/issues/25

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@njuguna-n njuguna-n marked this pull request as ready for review November 8, 2024 09:38
@njuguna-n njuguna-n requested a review from witash November 8, 2024 09:38
witash
witash approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@witash witash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for also refactoring sendEncounterToFhir for clarity, it was getting a bit chunky

@njuguna-n njuguna-n merged commit 670f3a5 into openmrs-mediator Nov 8, 2024
3 checks passed
@njuguna-n njuguna-n deleted the make-encounter-requests-idempotent branch November 8, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witash witash witash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njuguna-n @witash @njogz