Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build esm/cjs; fix jest #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build esm/cjs; fix jest #1

wants to merge 2 commits into from

Conversation

SCG82
Copy link
Contributor

@SCG82 SCG82 commented Dec 22, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2022

CLA assistant check
All committers have signed the CLA.

@SCG82
Copy link
Contributor Author

SCG82 commented Dec 22, 2022

@murillo128 @mildsunrise ready for review

@SCG82
Copy link
Contributor Author

SCG82 commented Dec 28, 2022

@mildsunrise rebased. Please let me know if you'll consider merging this.

@mildsunrise
Copy link
Contributor

hi, thanks for the PR and sorry for the delay in responding to this... it was something I was looking forward to merge but always had more important things in my desk.

let me see if I can bring these changes in, especially the buildsystem ones, it'd be nice to ship a cjs version


"module": "ES6",
"target": "es2020",
"lib": ["es2015", "es2016", "es2017", "es2018", "es2019", "es2020", "DOM"],
Copy link
Contributor

@mildsunrise mildsunrise Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do need the DOM library, at the very least for the sync directory which uses HTML5 APIs. I think it could be dropped for everything outside it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah I see it now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now I've removed the library from tsconfig, and instead used /// <reference lib="dom" /> in sync files. not good but better than nothing

@mildsunrise
Copy link
Contributor

I still have to merge some stuff, like windows support, but I think it's good enough for a v1 release.

Package is up on NPM, let me know if there's any issues :)
NPM rejected the original name (h264-frame-parser) as spam, so we've named it nal-extractor. I'll rename this repo.

@SCG82
Copy link
Contributor Author

SCG82 commented Feb 13, 2023

I still have to merge some stuff, like windows support, but I think it's good enough for a v1 release.

Package is up on NPM, let me know if there's any issues :) NPM rejected the original name (h264-frame-parser) as spam, so we've named it nal-extractor. I'll rename this repo.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants