chore: remove internal module resources option (#9582)

What: * removes resouces type "shared" or "isolated" from internal modules. * modules can have an isolated database connection by providing a database config as part of their options on `medusa-config` CLOSES: FRMW-2593
medusajs · Oct 17, 2024 · 902ac12 · 902ac12
1 parent b07dd33
commit 902ac12
Show file tree

Hide file tree

Showing 36 changed files with 75 additions and 258 deletions.
diff --git a/integration-tests/api/medusa-config.js b/integration-tests/api/medusa-config.js
@@ -42,7 +42,6 @@ module.exports = {
     [Modules.AUTH]: true,
     [Modules.USER]: {
       scope: "internal",
-      resources: "shared",
       resolve: "@medusajs/user",
       options: {
         jwt_secret: "test",

diff --git a/integration-tests/modules/medusa-config.js b/integration-tests/modules/medusa-config.js
@@ -52,7 +52,6 @@ module.exports = {
     },
     [Modules.USER]: {
       scope: "internal",
-      resources: "shared",
       resolve: "@medusajs/user",
       options: {
         jwt_secret: "test",

diff --git a/packages/core/modules-sdk/src/__mocks__/inventory-module.ts b/packages/core/modules-sdk/src/__mocks__/inventory-module.ts
@@ -9,7 +9,6 @@ export const InventoryModule = {
     dependencies: [],
     defaultModuleDeclaration: {
       scope: "internal",
-      resources: "shared",
     },
   },
   __joinerConfig: {

diff --git a/packages/core/modules-sdk/src/__mocks__/inventory-stock-location-link.ts b/packages/core/modules-sdk/src/__mocks__/inventory-stock-location-link.ts
@@ -8,7 +8,6 @@ export const InventoryStockLocationLink = {
     isQueryable: true,
     defaultModuleDeclaration: {
       scope: "internal",
-      resources: "shared",
     },
   },
   __joinerConfig: {

diff --git a/packages/core/modules-sdk/src/__mocks__/product-inventory-link.ts b/packages/core/modules-sdk/src/__mocks__/product-inventory-link.ts
@@ -8,7 +8,6 @@ export const ProductInventoryLinkModule = {
     isQueryable: true,
     defaultModuleDeclaration: {
       scope: "internal",
-      resources: "shared",
     },
   },
   __joinerConfig: {

diff --git a/packages/core/modules-sdk/src/__mocks__/product-module.ts b/packages/core/modules-sdk/src/__mocks__/product-module.ts
@@ -9,7 +9,6 @@ export const ProductModule = {
     dependencies: ["eventBusModuleService"],
     defaultModuleDeclaration: {
       scope: "internal",
-      resources: "shared",
     },
   },
   __joinerConfig: {

diff --git a/packages/core/modules-sdk/src/__mocks__/stock-location-module.ts b/packages/core/modules-sdk/src/__mocks__/stock-location-module.ts
@@ -9,7 +9,6 @@ export const StockLocationModule = {
     dependencies: ["eventBusModuleService"],
     defaultModuleDeclaration: {
       scope: "internal",
-      resources: "shared",
     },
   },
   __joinerConfig: {

diff --git a/packages/core/modules-sdk/src/definitions.ts b/packages/core/modules-sdk/src/definitions.ts
@@ -5,7 +5,7 @@ import {
   Modules,
   upperCaseFirst,
 } from "@medusajs/utils"
-import { MODULE_RESOURCE_TYPE, MODULE_SCOPE } from "./types"
+import { MODULE_SCOPE } from "./types"
 
 export const ModulesDefinition: {
   [key: string]: ModuleDefinition
@@ -19,7 +19,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.STOCK_LOCATION]: {
@@ -31,7 +30,6 @@ export const ModulesDefinition: {
     dependencies: [Modules.EVENT_BUS],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.INVENTORY]: {
@@ -43,7 +41,6 @@ export const ModulesDefinition: {
     dependencies: [Modules.EVENT_BUS],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.CACHE]: {
@@ -54,7 +51,6 @@ export const ModulesDefinition: {
     isQueryable: false,
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.PRODUCT]: {
@@ -66,7 +62,6 @@ export const ModulesDefinition: {
     dependencies: [Modules.EVENT_BUS, ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.PRICING]: {
@@ -78,7 +73,6 @@ export const ModulesDefinition: {
     dependencies: [Modules.EVENT_BUS, ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.PROMOTION]: {
@@ -90,7 +84,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.AUTH]: {
@@ -102,7 +95,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.WORKFLOW_ENGINE]: {
@@ -115,7 +107,6 @@ export const ModulesDefinition: {
     __passSharedContainer: true,
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.SALES_CHANNEL]: {
@@ -127,7 +118,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.FULFILLMENT]: {
@@ -139,7 +129,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER, Modules.EVENT_BUS],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.CART]: {
@@ -151,7 +140,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.CUSTOMER]: {
@@ -163,7 +151,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.PAYMENT]: {
@@ -175,7 +162,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.USER]: {
@@ -187,7 +173,6 @@ export const ModulesDefinition: {
     dependencies: [Modules.EVENT_BUS, ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.REGION]: {
@@ -199,7 +184,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.ORDER]: {
@@ -211,7 +195,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER, Modules.EVENT_BUS],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.TAX]: {
@@ -223,7 +206,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER, Modules.EVENT_BUS],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.API_KEY]: {
@@ -235,7 +217,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.STORE]: {
@@ -247,7 +228,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.CURRENCY]: {
@@ -259,7 +239,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.FILE]: {
@@ -271,7 +250,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.NOTIFICATION]: {
@@ -283,7 +261,6 @@ export const ModulesDefinition: {
     dependencies: [Modules.EVENT_BUS, ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.INDEX]: {
@@ -300,7 +277,6 @@ export const ModulesDefinition: {
     ],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
   [Modules.LOCKING]: {
@@ -312,7 +288,6 @@ export const ModulesDefinition: {
     dependencies: [ContainerRegistrationKeys.LOGGER],
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,
-      resources: MODULE_RESOURCE_TYPE.SHARED,
     },
   },
 }